PDA

View Full Version : [OPEN] [FIXED-227][3.x SVN] Messagebox alert has additional buttons



jburnhams
4 Sep 2009, 12:31 AM
Below example displays a messagebox with both the expected OK button, and Yes, No and cancel as well.


<html>
<head>
<link rel="stylesheet" type="text/css" href="../resources/css/ext-all.css" />
<script type="text/javascript" src="../adapter/ext/ext-base.js"></script>
<script type="text/javascript" src="../ext-all.js"></script>
</head>

<body>
<script type="text/javascript">
Ext.onReady(function(){
Ext.Msg.alert('Test', 'Test');
});
</script>
</body>
</html>

jburnhams
7 Sep 2009, 12:41 AM
Latest SVN now has error

buttons[k].el has no propertiesThe examples/message-box/msg-box.html page doesn't work either.

jburnhams
7 Sep 2009, 1:10 AM
The reason for the error is Revision 5288 in svn by evant:

[type]: fix
[module]: widgets
[id]: refs #224
[desc]: Added a fix to ensure children of toolbars have their reference set up correctly.
[priv]: Not going into the patch branch because these changes haven't been moved over.


Once this is reverted, no error is given but the bug I originally create this thread for still remains.

canxss
7 Sep 2009, 3:52 PM
Any progress about this problem?

In fact in these last two-three days, the changes in source produced so many basic bugs that I'm afraid to check out anymore :( All I'm doing is debugging errors and preparing test cases :s

evant
7 Sep 2009, 6:25 PM
Fix applied to svn in rev #5296 for patch release 3.1.

jburnhams
8 Sep 2009, 12:00 AM
Not fixed unfortunately, required change is as follows:

Ext.each(buttonNames, function(name){
btns.push(buttons[name] = new Ext.Button({
text: this.buttonText[name],
handler: handleButton.createCallback(name),
hideMode: 'offsets'
}));
}, this);It would have been good for your fix to be tried against my simple testcase before commiting.

elishnevsky
8 Sep 2009, 12:55 PM
jburnhams is right.

To be more specific Messagebox.js line 101 needs to be changed from this:


buttons.push(buttons[name] = new Ext.Button({


to this:


btns.push(buttons[name] = new Ext.Button({

evant
8 Sep 2009, 2:13 PM
Seems my file saving abilities are lacking, thanks for letting me know, this is now corrected.