PDA

View Full Version : [3.1.1] Duplicate Ext.data.Response definitions and misc related things



Scott Murawski
21 Feb 2010, 7:28 AM
I just started using the 3.1 series and I'm looking though the Store related code and noticed the Ext.data.Response (which I like, very nice to centralize that stuff) and searched around for it and saw two definitions!

On line 31778 of the 3.1.1 release and also line 35280 there's Ext.data.Response definitions. They are nearly the same.

On a side note, I noticed on line 35814 and on line 35843 this note:


// NOTE reader.readResponse does not currently return Ext.data.Response


It seems the reader.readResponse is actually the function that does return an Ext.data.Response and it's the other reader function named readRecords that doesn't, so I assume those notes are mixed up?

On an even more side note, there's a TODO on line 36169 which says


TODO: refactor code between JsonReader#readRecords, #readResponse into 1 method.


Does anyone know when that's planned on being done? That would be pretty nice.

evant
21 Feb 2010, 7:23 PM
From the looks, I'd say the one in Api.js is redundant.

The Ext.data package is being looked at, there's a number of things to be refactored there.