PDA

View Full Version : [FIXED-779] Bugs in treegrid.html and related js



menasce
24 Mar 2010, 9:10 AM
I tried your treegrid example for EXT-3.1.1 (treegrid.html)
Since I'm forced to use xhtml type for my project I changed the <html> tag in treegrid.html to


<html xmlns = "http://www.w3.org/1999/xhtml"
xmlns:svg = "http://www.w3.org/2000/svg"
xmlns:ext = "http://www.extjs.com"
xmlns:xlink = "http://www.w3.org/1999/xlink"</html>

So far so good. But then two html-syntax bugs (in ux/treegrid/TreeGrid.js and ux/treegrid/TreeGridNodeUI.js) prevent the example of running smoothly.

Here are my suggested fixes:

in ux/treegrid/TreeGrid.js, line 82: change


'</div></table>',

to


'</table>'

In ux/treegrid/TreeGridNodeUI.js line 27 and 28 change


'<img src="', this.emptyIcon, '" class="x-tree-ec-icon x-tree-elbow">',
'<img src="', a.icon || this.emptyIcon, '" class="x-tree-node-icon', (a.icon ? " x-tree-node-inline-icon" : ""), (a.iconCls ? " "+a.iconCls : ""), '" unselectable="on">',


'<img src="', this.emptyIcon, '" class="x-tree-ec-icon x-tree-elbow" />',
'<img src="', a.icon || this.emptyIcon, '" class="x-tree-node-icon', (a.icon ? " x-tree-node-inline-icon" : ""), (a.iconCls ? " "+a.iconCls : ""), '" unselectable="on" />',


(basically just add a / before the closing >)

With these fixes the example runs successufully also under the strict xhtml paradigm.

Hope this might be useful for others (it certainly is for me)

Cheers, Dario

evant
20 Jun 2010, 9:43 PM
This has been fixed in SVN, thanks for the report.