PDA

View Full Version : RadioGroup isDirty function incorrect?



abeal
4 May 2010, 9:39 AM
I'm not sure of the previous behavior, but it looks like at least in this release (3.2.1), the Ext.form.RadioGroup getValue() method returns an Ext.form.Radio object. This, or the isDirty method looks like an error:


//RadioGroup isDirty method:
isDirty : function() {
if(this.disabled || !this.rendered) {
return false;
}
return String(this.getValue()) !== String(this.originalValue);
},

This seems like it would compare the two strings "[object Object]" and "[object Object]". Perhaps instead, it should be something like so?:


if(this.disabled || !this.rendered) {
return false;
}
return String(this.getValue().getValue()) !== String(this.originalValue.getValue());

I thought I'd put this here for comments before I filed a bug report, in case I'm misunderstanding something.