Results 1 to 2 of 2

Thread: [OPEN]Ext.Controller calls 'render' with wrong arguments

    Thank you for reporting this bug. We will make it our priority to review this report.
  1. #1
    Sencha User Condor's Avatar
    Join Date
    Mar 2007
    The Netherlands
    Vote Rating

    Default [OPEN]Ext.Controller calls 'render' with wrong arguments

    On 2010-09-07 Ed changed the parameters of the Ext.Controller render() method from (viewName, config) to (config, target).

    1. The API docs for the method were not corrected.
    2. The index(), edit() and build() methods still use the old parameters, so they will fail.

    Are you planning on re-adding default support for Model editing to Ext.Controller or should all model related methods be removed?

    Other issues:
    3. The control() method references undefined properties 'isView' and 'refs', so it's useless.
    4. The render() method assumes that a profile is an Ext.Profile instance, but it's just a simple String. This means that the method will fail if you create an application with profiles before the controller.
    5. The render() method uses createByAlias without a 'widget.' prefix. It should be using:
    view = Ext.create(config);
    IMHO Ext.Controller needs a complete rewrite.

  2. #2
    Sencha User GraemeBryce's Avatar
    Join Date
    Sep 2007
    Vote Rating


    I have spent hours trying to find examples of the correct use of Ext.Controller.control() and finally looked at the source to find the isView value which is never set by any Sencha code.

    This definitely required attention.

    The potential to have a controller perform the bindings between UI components and actions seams to be a valid pattern that will create more readable code and permit the use case where several controllers may listen to the same UI event at different times in the application lifecycle.

Similar Threads

  1. No controller.render callback?
    By mindstuff in forum Sencha Touch 1.x: Discussion
    Replies: 0
    Last Post: 21 Dec 2010, 4:15 PM
  2. [OPEN-675] Controller.render() documentation wrong
    By estesbubba in forum Sencha Touch 1.x: Bugs
    Replies: 0
    Last Post: 17 Dec 2010, 12:45 PM
  3. Replies: 4
    Last Post: 19 May 2010, 2:08 PM
  4. Passing arguments to Spring controller
    By ejml in forum Ext 2.x: Help & Discussion
    Replies: 0
    Last Post: 26 Feb 2009, 7:25 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts