Hybrid View

    Success! Looks like we've fixed this one. According to our records the fix was applied for EXTJS-4455 in a recent build.
  1. #1
    Sencha User
    Join Date
    Dec 2009
    Location
    Enschede, The Netherlands
    Posts
    327
    Vote Rating
    13
    flanders will become famous soon enough

      1  

    Default App freezes when an incorrect query is passed to Ext.app.Controller.control()

    Ext version:
    4.0.7
    Browsers:
    Chrome, Chromium, FF
    Description:
    The complete page can freeze when an incorrect component query is passed to Ext.app.Controller.control()
    Steps to recreate the problem:
    • Insert an incorrect component query into control()
    • When continueing working in the application it can freeze at complete unrelated points in the code. (Most likely because another event occurs at that point)
    Expected result:
    The faulty query is either silently ignored or an warning/error is generated

    Example:
    Code:
    Ext.define('ecms.controller.Headers', {
        extend: 'Ext.app.Controller',
        
        init: function() {
            this.control({
                'headerform button[action=cancel]]': { //note the double "]"
                    click: this.onCancelClick
                },
                'headerform button[action=cancel], headerform button[action=add]': {
                        // an intinuative mistake seen before when the programmer is working with css as well
                    click: this.onAnyClick
                }
    
    
            });
        },
    
    
        ...
    });

  2. #2
    Sencha User
    Join Date
    Dec 2008
    Location
    The Netherlands
    Posts
    61
    Vote Rating
    0
    daanlib is on a distinguished road

      0  

    Default

    "Working" example: http://jsfiddle.net/WpD9C/13/

    Click the expand/collapse +sign to freeze your tab. This is caused by the extra "]" in the component query in controller.control().

    This fiddle is using 4.0.2a, but the result is the same.

    Warning: this example will crash your browser (IE), or freeze your tab (real browsers )

  3. #3
    Sencha User
    Join Date
    Dec 2009
    Location
    Enschede, The Netherlands
    Posts
    327
    Vote Rating
    13
    flanders will become famous soon enough

      0  

    Default

    ..bump..

    To be honest I was hoping for an response from the dev's. Would they qualify this as a bug? And if not, should it be a feature request?

    Personally I think this needs addressing

  4. #4
    Sencha - Services Team hendricd's Avatar
    Join Date
    Aug 2007
    Location
    Long Island, NY USA
    Posts
    5,965
    Vote Rating
    12
    hendricd will become famous soon enough hendricd will become famous soon enough

      0  

    Default

    Thanks for the report.

    Indeed, the query parser needs some 'hardening'.

    If you stop execution of the jsFiddle sample (thx @danlib) with the Chrome debugger after trying to collapse the tree, you can see it's stuck trying to figure out what to do with the final ']'.
    "be dom-ready..."
    Doug Hendricks

    Maintaining ux: ManagedIFrame, MIF2 (FAQ, Wiki), ux.Media/Flash, AudioEvents, ux.Chart[Fusion,OFC,amChart], ext-basex.js/$JIT, Documentation Site.


    Got Sencha licensing questions? Find out more here.


  5. #5
    Sencha User VDP's Avatar
    Join Date
    Feb 2012
    Location
    Boom, Belgium
    Posts
    88
    Vote Rating
    10
    VDP will become famous soon enough

      0  

    Default

    Thanx for the report! My browser froze and I didn't knew why. Then I read this and yes.. It was an incomplete CQ.

Thread Participants: 3