1. #21
    Sencha User ykey's Avatar
    Join Date
    Mar 2010
    Location
    USA
    Posts
    245
    Vote Rating
    27
    ykey has a spectacular aura about ykey has a spectacular aura about

      0  

    Default

    We are seeing issues in 4.1.1 with form field labels pushing the editor outside of the form when it has a specified width. Also labelAlign: 'top' on the field causes the field label to render in between the toolbar and the codemirror editor.

  2. #22
    Sencha - Ext JS Dev Team
    Join Date
    Dec 2009
    Location
    Iasi, Romania
    Posts
    108
    Vote Rating
    20
    ateodorescu will become famous soon enough ateodorescu will become famous soon enough

      0  

    Default

    Hi Daniel,

    If I add that fix you suggested the component will work properly with the latest version of CodeMirror (2.32)? I didn't test the latest version yet. I'm still using 2.25.

    Cheers,
    Adrian

  3. #23
    Sencha - Ext JS Dev Team
    Join Date
    Dec 2009
    Location
    Iasi, Romania
    Posts
    108
    Vote Rating
    20
    ateodorescu will become famous soon enough ateodorescu will become famous soon enough

      0  

    Default

    Quote Originally Posted by ykey View Post
    We are seeing issues in 4.1.1 with form field labels pushing the editor outside of the form when it has a specified width. Also labelAlign: 'top' on the field causes the field label to render in between the toolbar and the codemirror editor.
    Hi,
    Thanks for reporting it. I have fixed that issue. You should get the latest version.

    Cheers,
    Adrian

  4. #24
    Sencha - Ext JS Dev Team
    Join Date
    Dec 2009
    Location
    Iasi, Romania
    Posts
    108
    Vote Rating
    20
    ateodorescu will become famous soon enough ateodorescu will become famous soon enough

      0  

    Default

    Quote Originally Posted by koblass View Post
    Hi Adrian,

    Thanks for the correction and thanks for the small plugin example.

    I've one more thing to suggest.
    In the current version the special char (like enter, space, etc...) are not handle properly by code mirror. I had to change the onKeyEvent method a bit in the initComponent method, just by canceling the bubble.
    The code result like this :

    Code:
    onKeyEvent:         function(editor, event){
        event.cancelBubble = true;
        me.fireEvent('keyevent', me, event);
    }
    Best
    Daniel
    I have fixed that. You should get the latest version.

    Cheers,
    Adrian

  5. #25
    Sencha - Ext JS Dev Team
    Join Date
    Dec 2009
    Location
    Iasi, Romania
    Posts
    108
    Vote Rating
    20
    ateodorescu will become famous soon enough ateodorescu will become famous soon enough

      0  

    Default

    Update: The project is on Github now: https://github.com/ateodorescu/mzExt

  6. #26
    Sencha Premium Member
    Join Date
    Mar 2012
    Posts
    3
    Vote Rating
    0
    mr0mega is on a distinguished road

      0  

    Default

    I get the following exception

    Code:
    from your example site http://ateodorescu.github.com/mzExt/...index_411.html if I modify it so that when I click a button it will open the window again (once I've closed it). The first display of the window is fine.

  7. #27
    Sencha - Ext JS Dev Team
    Join Date
    Dec 2009
    Location
    Iasi, Romania
    Posts
    108
    Vote Rating
    20
    ateodorescu will become famous soon enough ateodorescu will become famous soon enough

      0  

    Default

    Quote Originally Posted by mr0mega View Post
    I get the following exception

    Code:
    from your example site http://ateodorescu.github.com/mzExt/...index_411.html if I modify it so that when I click a button it will open the window again (once I've closed it). The first display of the window is fine.
    I have managed to reproduce the error. If you change the code and remove the codemirror field from the form you will see that you will still get the same error. It's probably a bug in Extjs and not related to my codemirror component.

    Cheers,
    Adrian
    https://github.com/ateodorescu/mzExt
    http://www.mzsolutions.eu/

    Mz.pivot.Grid
    Ext.ux.form.plugin.HtmlEditor
    Ext.ux.form.field.CodeMirror
    Ext.ux.form.field.ImageFileField
    Ext.ux.form.field.UploadFileField

  8. #28
    Sencha - Community Support Team mankz's Avatar
    Join Date
    Nov 2007
    Location
    Stockholm, Sweden
    Posts
    2,873
    Vote Rating
    154
    mankz is a splendid one to behold mankz is a splendid one to behold mankz is a splendid one to behold mankz is a splendid one to behold mankz is a splendid one to behold mankz is a splendid one to behold mankz is a splendid one to behold

      0  

    Default

    Nice, minor issue: global variable leak in onDestroy (missing 'var').

    Code:
                    for (prop in me.editor) {

  9. #29
    Sencha - Ext JS Dev Team
    Join Date
    Dec 2009
    Location
    Iasi, Romania
    Posts
    108
    Vote Rating
    20
    ateodorescu will become famous soon enough ateodorescu will become famous soon enough

      0  

    Default

    Just updated my github account with a new version of CodeMirror component. This guy works with CM 3.20 and ExtJS 4.0.7, 4.1.x and 4.2.x.

    The memory leak reported by Mats was fixed. Thanks, btw.
    https://github.com/ateodorescu/mzExt
    https://github.com/ateodorescu/mzExt
    http://www.mzsolutions.eu/

    Mz.pivot.Grid
    Ext.ux.form.plugin.HtmlEditor
    Ext.ux.form.field.CodeMirror
    Ext.ux.form.field.ImageFileField
    Ext.ux.form.field.UploadFileField

  10. #30
    Sencha User
    Join Date
    Dec 2011
    Posts
    5
    Vote Rating
    0
    subshark is on a distinguished road

      0  

    Default

    Hello!How add other utils to you component? For example autocompletition http://codemirror.net/demo/xmlcomplete.html?