Results 1 to 9 of 9

Thread: [4.1-(b(1|2|3)|rc1)] Sass >= 3.1.8 Deprecation Warnings

    Looks like we cannot reproduce this. Please provide another test case to reproduce this issue.
  1. #1
    Sencha User mystix's Avatar
    Join Date
    Mar 2007
    Location
    Singapore
    Posts
    6,236

    Default [4.1-(b(1|2|3)|rc1)] Sass >= 3.1.8 Deprecation Warnings

    Compiling themes using Sass >= 3.1.8 results in the following deprecation warnings:
    Code:
    DEPRECATION WARNING:
    On line 816 of "ext-4.1.0-beta-1/resources/themes/stylesheets/ext4/default/widgets/_grid.scss", after "        &"
    Starting in Sass 3.2, "-ml" may only be used at the beginning of a selector.
    
    DEPRECATION WARNING:
    On line 817 of "ext-4.1.0-beta-1/resources/themes/stylesheets/ext4/default/widgets/_grid.scss", after "        &"
    Starting in Sass 3.2, "-mr" may only be used at the beginning of a selector.
    
    DEPRECATION WARNING:
    On line 818 of "ext-4.1.0-beta-1/resources/themes/stylesheets/ext4/default/widgets/_grid.scss", after "        &"
    Starting in Sass 3.2, "-bl" may only be used at the beginning of a selector.
    
    DEPRECATION WARNING:
    On line 819 of "ext-4.1.0-beta-1/resources/themes/stylesheets/ext4/default/widgets/_grid.scss", after "        &"
    Starting in Sass 3.2, "-br" may only be used at the beginning of a selector.
    
    DEPRECATION WARNING:
    On line 820 of "ext-4.1.0-beta-1/resources/themes/stylesheets/ext4/default/widgets/_grid.scss", after "        &"
    Starting in Sass 3.2, "-bc" may only be used at the beginning of a selector.
    
    DEPRECATION WARNING:
    On line 825 of "ext-4.1.0-beta-1/resources/themes/stylesheets/ext4/default/widgets/_grid.scss", after "        &"
    Starting in Sass 3.2, "-bl" may only be used at the beginning of a selector.
    
    DEPRECATION WARNING:
    On line 826 of "ext-4.1.0-beta-1/resources/themes/stylesheets/ext4/default/widgets/_grid.scss", after "        &"
    Starting in Sass 3.2, "-br" may only be used at the beginning of a selector.
    
    DEPRECATION WARNING:
    On line 832 of "ext-4.1.0-beta-1/resources/themes/stylesheets/ext4/default/widgets/_grid.scss", after "        &"
    Starting in Sass 3.2, "-bl" may only be used at the beginning of a selector.
    
    DEPRECATION WARNING:
    On line 836 of "ext-4.1.0-beta-1/resources/themes/stylesheets/ext4/default/widgets/_grid.scss", after "        &"
    Starting in Sass 3.2, "-br" may only be used at the beginning of a selector.
    
    DEPRECATION WARNING:
    On line 841 of "ext-4.1.0-beta-1/resources/themes/stylesheets/ext4/default/widgets/_grid.scss", after "        &"
    Starting in Sass 3.2, "-bc" may only be used at the beginning of a selector.
    
    DEPRECATION WARNING:
    On line 850 of "ext-4.1.0-beta-1/resources/themes/stylesheets/ext4/default/widgets/_grid.scss", after "        &"
    Starting in Sass 3.2, "-ml" may only be used at the beginning of a selector.
    
    DEPRECATION WARNING:
    On line 851 of "ext-4.1.0-beta-1/resources/themes/stylesheets/ext4/default/widgets/_grid.scss", after "        &"
    Starting in Sass 3.2, "-mr" may only be used at the beginning of a selector.
    
    DEPRECATION WARNING:
    On line 857 of "ext-4.1.0-beta-1/resources/themes/stylesheets/ext4/default/widgets/_grid.scss", after "        &"
    Starting in Sass 3.2, "-ml" may only be used at the beginning of a selector.
    
    DEPRECATION WARNING:
    On line 860 of "ext-4.1.0-beta-1/resources/themes/stylesheets/ext4/default/widgets/_grid.scss", after "        &"
    Starting in Sass 3.2, "-mr" may only be used at the beginning of a selector.
    This is caused by a deprecated use of the ampersand in Sass 3.1.8, as documented in
    https://github.com/nex3/sass/blob/ma..._CHANGELOG.md:
    Deprecate parent selectors followed immediately by identifiers (e.g. &foo). This should never have worked, since it violates the rule of & only being usable where an element selector would.
    The following diff patch resolves the problem (code inlined for convenience):
    Code:
    diff --git a/resources/themes/stylesheets/ext4/default/widgets/_grid.scss b/resources/themes/stylesheets/ext4/default/widgets/_grid.scss
    index 3162f06..4e11bea 100644
    --- a/resources/themes/stylesheets/ext4/default/widgets/_grid.scss
    +++ b/resources/themes/stylesheets/ext4/default/widgets/_grid.scss
    @@ -696,7 +696,7 @@
                 padding-top: $grid-cell-editor-checkbox-padding-top;
             }
         }
    -  
    +
         // Row Editor
         .#{$prefix}grid-row-editor {
             position: absolute !important;
    @@ -799,9 +799,10 @@
                 }
             }
         }
    - 
     
    -.#{$prefix}grid-row-editor-buttons {
    +$grid-reb: #{$prefix}grid-row-editor-buttons;
    +
    +.#{$grid-reb} {
             background-color: $grid-row-editor-background-color;
             position: absolute;
             bottom: -31px;
    @@ -813,32 +814,32 @@
                 height: 24px;
             }
     
    -        &-ml,
    -        &-mr,
    -        &-bl,
    -        &-br,
    -        &-bc {
    +        .#{$grid-reb}-ml,
    +        .#{$grid-reb}-mr,
    +        .#{$grid-reb}-bl,
    +        .#{$grid-reb}-br,
    +        .#{$grid-reb}-bc {
                 position: absolute;
                 overflow: hidden;
             }
     
    -        &-bl,
    -        &-br {
    +        .#{$grid-reb}-bl,
    +        .#{$grid-reb}-br {
                 width: 4px;
                 height: 4px;
                 bottom: 0px;
                 background-image: theme-background-image($theme-name, 'panel/panel-default-framed-corners.gif');
             }
    -        &-bl {
    +        .#{$grid-reb}-bl {
                 left: 0px;
                 background-position: 0px -16px;
             }
    -        &-br {
    +        .#{$grid-reb}-br {
                 right: 0px;
                 background-position: 0px -20px;
             }
     
    -        &-bc {
    +        .#{$grid-reb}-bc {
                 position: absolute;
                 left: 4px;
                 bottom: 0px;
    @@ -847,17 +848,17 @@
                 background-color: $grid-row-editor-border-color;
             }
     
    -        &-ml,
    -        &-mr {
    +        .#{$grid-reb}-ml,
    +        .#{$grid-reb}-mr {
                 height: 27px;
                 width: 1px;
                 top: 1px;
                 background-color: $grid-row-editor-border-color;
             }
    -        &-ml {
    +        .#{$grid-reb}-ml {
                 left: 0px
             }
    -        &-mr {
    +        .#{$grid-reb}-mr {
                 background-position: 0px -20px;
                 right: 0px;
             }
    diff --git a/resources/themes/stylesheets/neptune/default/widgets/_grid.scss b/resources/themes/stylesheets/neptune/default/widgets/_grid.scss
    index 42ed78a..6df76ee 100644
    --- a/resources/themes/stylesheets/neptune/default/widgets/_grid.scss
    +++ b/resources/themes/stylesheets/neptune/default/widgets/_grid.scss
    @@ -77,7 +77,7 @@
             position: absolute;
             overflow: hidden;
     
    -        -webkit-border-image: theme-background-image($theme-name, 'grid/header-border.png') 1 1 1 1 stretch stretch; 
    +        -webkit-border-image: theme-background-image($theme-name, 'grid/header-border.png') 1 1 1 1 stretch stretch;
     
     
             border-right: 1px solid $grid-header-border-color;
    @@ -723,7 +723,7 @@
                 padding-top: $grid-cell-editor-checkbox-padding-top;
             }
         }
    -  
    +
         // Row Editor
         .#{$prefix}grid-row-editor {
             position: absolute !important;
    @@ -826,13 +826,14 @@
                 }
             }
         }
    - 
    +
     
         $grid-row-editor-btns-width: 200px;
         $grid-row-editor-btns-height: 32px;
         $grid-row-editor-btns-padding: 4px;
    +	$grid-reb: #{$prefix}grid-row-editor-buttons;
     
    -    .#{$prefix}grid-row-editor-buttons {
    +    .#{$grid-reb} {
             background-color: $grid-row-editor-background-color;
             position: absolute;
             bottom: -31px;
    @@ -845,26 +846,26 @@
             }
     
             // @todo Doc these abbreviations here
    -        &-ml, &-mr, &-bl, &-br, &-bc {
    +        .#{$grid-reb}-ml, .#{$grid-reb}-mr, .#{$grid-reb}-bl, .#{$grid-reb}-br, .#{$grid-reb}-bc {
                 position: absolute;
                 overflow: hidden;
             }
     
    -        &-bl, &-br {
    +        .#{$grid-reb}-bl, .#{$grid-reb}-br {
                 width: 4px;
                 height: 4px;
                 bottom: 0px;
                 background-image: theme-background-image($theme-name, 'panel/panel-default-framed-corners.gif');
             }
    -        &-bl {
    +        .#{$grid-reb}-bl {
                 left: 0px;
                 background-position: 0px -16px;
             }
    -        &-br {
    +        .#{$grid-reb}-br {
                 right: 0px;
                 background-position: 0px -20px;
             }
    -        &-bc {
    +        .#{$grid-reb}-bc {
                 position: absolute;
                 left: 4px;
                 bottom: 0px;
    @@ -872,16 +873,16 @@
                 height: 1px;
                 background-color: $grid-row-editor-border-color;
             }
    -        &-ml, &-mr {
    +        .#{$grid-reb}-ml, .#{$grid-reb}-mr {
                 height: 27px;
                 width: 1px;
                 top: 1px;
                 background-color: $grid-row-editor-border-color;
             }
    -        &-ml {
    +        .#{$grid-reb}-ml {
                 left: 0px
             }
    -        &-mr {
    +        .#{$grid-reb}-mr {
                 background-position: 0px -20px;
                 right: 0px;
             }
    This fix will work for Sass < 3.1.8 since it uses standard Sass syntax.


    [edit]
    note: this patch from https://www.sencha.com/forum/showthread.php?t=158358 will need to be applied first to fix an earlier unresolved Sass bug.

  2. #2
    Sencha Premium User mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    40,449

    Default

    Not seeing these and I am using 3.2.0 but am still pushing up as I'm not a SASS expert
    Mitchell Simoens @LikelyMitch
    Modus Create, Senior Fullstack Engineer
    ________________
    Modus Create is based on the model of an open source team. We’re a remote, global team of experts in our field. To find out more about the work we do, head over to our website.

    Check out my GitHub:
    https://github.com/mitchellsimoens

  3. #3
    Sencha User mystix's Avatar
    Join Date
    Mar 2007
    Location
    Singapore
    Posts
    6,236

    Default

    strange... try running the following test.scss file through sass-3.2.0:
    Code:
    .happy {
        &-new-year {
            border: 1px solid black;
        }    
    }
    using sass-3.1.12 I see the deprecation warnings, which (unfortunately) indicate the wrong problem source (sass thinks -new-year is a browser prefix).

    p.s. I'm no sass-pert either. I just started fiddling with it today.

  4. #4
    Sencha User mystix's Avatar
    Join Date
    Mar 2007
    Location
    Singapore
    Posts
    6,236

    Default

    It appears SASS caches stuff by default, so after the deprecation warnings are shown for the very 1st time, subsequent sass runs will silence those warnings. You'll need to run sass with the --no-cache flag to consistently see those warnings.

  5. #5
    Sencha User mystix's Avatar
    Join Date
    Mar 2007
    Location
    Singapore
    Posts
    6,236

    Default updated diff patch for 4.1b2

    Updated diff patch for 4.1b2:
    Code:
    diff --git a/resources/themes/stylesheets/ext4/default/widgets/_grid.scss b/resources/themes/stylesheets/ext4/default/widgets/_grid.scss
    index ffe0c29..55dc78c 100644
    --- a/resources/themes/stylesheets/ext4/default/widgets/_grid.scss
    +++ b/resources/themes/stylesheets/ext4/default/widgets/_grid.scss
    @@ -703,7 +703,7 @@
                 padding-top: $grid-cell-editor-checkbox-padding-top;
             }
         }
    -  
    +
         // Row Editor
         .#{$prefix}grid-row-editor {
             position: absolute !important;
    @@ -806,9 +806,10 @@
                 }
             }
         }
    - 
     
    -.#{$prefix}grid-row-editor-buttons {
    +$grid-reb: #{$prefix}grid-row-editor-buttons;
    +
    +.#{$grid-reb} {
             background-color: $grid-row-editor-background-color;
             position: absolute;
             bottom: -31px;
    @@ -820,32 +821,32 @@
                 height: 24px;
             }
     
    -        &-ml,
    -        &-mr,
    -        &-bl,
    -        &-br,
    -        &-bc {
    +        .#{$grid-reb}-ml,
    +        .#{$grid-reb}-mr,
    +        .#{$grid-reb}-bl,
    +        .#{$grid-reb}-br,
    +        .#{$grid-reb}-bc {
                 position: absolute;
                 overflow: hidden;
             }
     
    -        &-bl,
    -        &-br {
    +        .#{$grid-reb}-bl,
    +        .#{$grid-reb}-br {
                 width: 4px;
                 height: 4px;
                 bottom: 0px;
                 background-image: theme-background-image($theme-name, 'panel/panel-default-framed-corners.gif');
             }
    -        &-bl {
    +        .#{$grid-reb}-bl {
                 left: 0px;
                 background-position: 0px -16px;
             }
    -        &-br {
    +        .#{$grid-reb}-br {
                 right: 0px;
                 background-position: 0px -20px;
             }
     
    -        &-bc {
    +        .#{$grid-reb}-bc {
                 position: absolute;
                 left: 4px;
                 bottom: 0px;
    @@ -854,17 +855,17 @@
                 background-color: $grid-row-editor-border-color;
             }
     
    -        &-ml,
    -        &-mr {
    +        .#{$grid-reb}-ml,
    +        .#{$grid-reb}-mr {
                 height: 27px;
                 width: 1px;
                 top: 1px;
                 background-color: $grid-row-editor-border-color;
             }
    -        &-ml {
    +        .#{$grid-reb}-ml {
                 left: 0px
             }
    -        &-mr {
    +        .#{$grid-reb}-mr {
                 background-position: 0px -20px;
                 right: 0px;
             }
    diff --git a/resources/themes/stylesheets/neptune/default/widgets/_grid.scss b/resources/themes/stylesheets/neptune/default/widgets/_grid.scss
    index b09e732..0d4ff2b 100644
    --- a/resources/themes/stylesheets/neptune/default/widgets/_grid.scss
    +++ b/resources/themes/stylesheets/neptune/default/widgets/_grid.scss
    @@ -80,7 +80,7 @@
             position: absolute;
             overflow: hidden;
     
    -        -webkit-border-image: theme-background-image($theme-name, 'grid/header-border.png') 1 1 1 1 stretch stretch; 
    +        -webkit-border-image: theme-background-image($theme-name, 'grid/header-border.png') 1 1 1 1 stretch stretch;
     
     
             border-right: 1px solid $grid-header-border-color;
    @@ -725,7 +725,7 @@
                 padding-top: $grid-cell-editor-checkbox-padding-top;
             }
         }
    -  
    +
         // Row Editor
         .#{$prefix}grid-row-editor {
             position: absolute !important;
    @@ -833,8 +833,9 @@
         $grid-row-editor-btns-width: 200px;
         $grid-row-editor-btns-height: 32px;
         $grid-row-editor-btns-padding: 4px;
    +	$grid-reb: #{$prefix}grid-row-editor-buttons;
     
    -    .#{$prefix}grid-row-editor-buttons {
    +    .#{$grid-reb} {
             background-color: $grid-row-editor-background-color;
             position: absolute;
             bottom: -31px;
    @@ -847,26 +848,26 @@
             }
     
             // @todo Doc these abbreviations here
    -        &-ml, &-mr, &-bl, &-br, &-bc {
    +        .#{$grid-reb}-ml, .#{$grid-reb}-mr, .#{$grid-reb}-bl, .#{$grid-reb}-br, .#{$grid-reb}-bc {
                 position: absolute;
                 overflow: hidden;
             }
     
    -        &-bl, &-br {
    +        .#{$grid-reb}-bl, .#{$grid-reb}-br {
                 width: 4px;
                 height: 4px;
                 bottom: 0px;
                 background-image: theme-background-image($theme-name, 'panel/panel-default-framed-corners.gif');
             }
    -        &-bl {
    +        .#{$grid-reb}-bl {
                 left: 0px;
                 background-position: 0px -16px;
             }
    -        &-br {
    +        .#{$grid-reb}-br {
                 right: 0px;
                 background-position: 0px -20px;
             }
    -        &-bc {
    +        .#{$grid-reb}-bc {
                 position: absolute;
                 left: 4px;
                 bottom: 0px;
    @@ -874,16 +875,16 @@
                 height: 1px;
                 background-color: $grid-row-editor-border-color;
             }
    -        &-ml, &-mr {
    +        .#{$grid-reb}-ml, .#{$grid-reb}-mr {
                 height: 27px;
                 width: 1px;
                 top: 1px;
                 background-color: $grid-row-editor-border-color;
             }
    -        &-ml {
    +        .#{$grid-reb}-ml {
                 left: 0px
             }
    -        &-mr {
    +        .#{$grid-reb}-mr {
                 background-position: 0px -20px;
                 right: 0px;
             }

  6. #6
    Sencha User mystix's Avatar
    Join Date
    Mar 2007
    Location
    Singapore
    Posts
    6,236

    Default

    Updated diff patch for 4.1.0-rc1:

    Code:
    diff --git a/resources/themes/stylesheets/ext4/default/widgets/_grid.scss b/resources/themes/stylesheets/ext4/default/widgets/_grid.scss
    index 0356d02..74e949d 100644
    --- a/resources/themes/stylesheets/ext4/default/widgets/_grid.scss
    +++ b/resources/themes/stylesheets/ext4/default/widgets/_grid.scss
    @@ -806,7 +806,9 @@
         }
      
     
    -.#{$prefix}grid-row-editor-buttons {
    +$grid-reb: #{$prefix}grid-row-editor-buttons;
    +
    +.#{$grid-reb} {
             background-color: $grid-row-editor-background-color;
             position: absolute;
             bottom: -31px;
    @@ -818,32 +820,32 @@
                 height: 24px;
             }
     
    -        &-ml,
    -        &-mr,
    -        &-bl,
    -        &-br,
    -        &-bc {
    +        .#{$grid-reb}-ml,
    +        .#{$grid-reb}-mr,
    +        .#{$grid-reb}-bl,
    +        .#{$grid-reb}-br,
    +        .#{$grid-reb}-bc {
                 position: absolute;
                 overflow: hidden;
             }
     
    -        &-bl,
    -        &-br {
    +        .#{$grid-reb}-bl,
    +        .#{$grid-reb}-br {
                 width: 4px;
                 height: 4px;
                 bottom: 0px;
                 background-image: theme-background-image($theme-name, 'panel/panel-default-framed-corners.gif');
             }
    -        &-bl {
    +        .#{$grid-reb}-bl {
                 left: 0px;
                 background-position: 0px -16px;
             }
    -        &-br {
    +        .#{$grid-reb}-br {
                 right: 0px;
                 background-position: 0px -20px;
             }
     
    -        &-bc {
    +        .#{$grid-reb}-bc {
                 position: absolute;
                 left: 4px;
                 bottom: 0px;
    @@ -852,17 +854,17 @@
                 background-color: $grid-row-editor-border-color;
             }
     
    -        &-ml,
    -        &-mr {
    +        .#{$grid-reb}-ml,
    +        .#{$grid-reb}-mr {
                 height: 27px;
                 width: 1px;
                 top: 1px;
                 background-color: $grid-row-editor-border-color;
             }
    -        &-ml {
    +        .#{$grid-reb}-ml {
                 left: 0px
             }
    -        &-mr {
    +        .#{$grid-reb}-mr {
                 background-position: 0px -20px;
                 right: 0px;
             }
    diff --git a/resources/themes/stylesheets/neptune/default/widgets/_grid.scss b/resources/themes/stylesheets/neptune/default/widgets/_grid.scss
    index b09e732..0d4ff2b 100644
    --- a/resources/themes/stylesheets/neptune/default/widgets/_grid.scss
    +++ b/resources/themes/stylesheets/neptune/default/widgets/_grid.scss
    @@ -80,7 +80,7 @@
             position: absolute;
             overflow: hidden;
     
    -        -webkit-border-image: theme-background-image($theme-name, 'grid/header-border.png') 1 1 1 1 stretch stretch; 
    +        -webkit-border-image: theme-background-image($theme-name, 'grid/header-border.png') 1 1 1 1 stretch stretch;
     
     
             border-right: 1px solid $grid-header-border-color;
    @@ -725,7 +725,7 @@
                 padding-top: $grid-cell-editor-checkbox-padding-top;
             }
         }
    -  
    +
         // Row Editor
         .#{$prefix}grid-row-editor {
             position: absolute !important;
    @@ -833,8 +833,9 @@
         $grid-row-editor-btns-width: 200px;
         $grid-row-editor-btns-height: 32px;
         $grid-row-editor-btns-padding: 4px;
    +	$grid-reb: #{$prefix}grid-row-editor-buttons;
     
    -    .#{$prefix}grid-row-editor-buttons {
    +    .#{$grid-reb} {
             background-color: $grid-row-editor-background-color;
             position: absolute;
             bottom: -31px;
    @@ -847,26 +848,26 @@
             }
     
             // @todo Doc these abbreviations here
    -        &-ml, &-mr, &-bl, &-br, &-bc {
    +        .#{$grid-reb}-ml, .#{$grid-reb}-mr, .#{$grid-reb}-bl, .#{$grid-reb}-br, .#{$grid-reb}-bc {
                 position: absolute;
                 overflow: hidden;
             }
     
    -        &-bl, &-br {
    +        .#{$grid-reb}-bl, .#{$grid-reb}-br {
                 width: 4px;
                 height: 4px;
                 bottom: 0px;
                 background-image: theme-background-image($theme-name, 'panel/panel-default-framed-corners.gif');
             }
    -        &-bl {
    +        .#{$grid-reb}-bl {
                 left: 0px;
                 background-position: 0px -16px;
             }
    -        &-br {
    +        .#{$grid-reb}-br {
                 right: 0px;
                 background-position: 0px -20px;
             }
    -        &-bc {
    +        .#{$grid-reb}-bc {
                 position: absolute;
                 left: 4px;
                 bottom: 0px;
    @@ -874,16 +875,16 @@
                 height: 1px;
                 background-color: $grid-row-editor-border-color;
             }
    -        &-ml, &-mr {
    +        .#{$grid-reb}-ml, .#{$grid-reb}-mr {
                 height: 27px;
                 width: 1px;
                 top: 1px;
                 background-color: $grid-row-editor-border-color;
             }
    -        &-ml {
    +        .#{$grid-reb}-ml {
                 left: 0px
             }
    -        &-mr {
    +        .#{$grid-reb}-mr {
                 background-position: 0px -20px;
                 right: 0px;
             }

  7. #7
    Sencha User mystix's Avatar
    Join Date
    Mar 2007
    Location
    Singapore
    Posts
    6,236

    Default

    Woot... I can confirm this is fixed in 4.1.0-rc2. Thanks!

  8. #8

    Default

    Yay! I've confirmed this as well.

    Though the ticket status at the top of the thread is still marked as open... interesting.

  9. #9
    Sencha Premium User mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    40,449

    Default

    Quote Originally Posted by burnnat View Post
    Yay! I've confirmed this as well.

    Though the ticket status at the top of the thread is still marked as open... interesting.
    Looks like it got fixed in another fix.
    Mitchell Simoens @LikelyMitch
    Modus Create, Senior Fullstack Engineer
    ________________
    Modus Create is based on the model of an open source team. We’re a remote, global team of experts in our field. To find out more about the work we do, head over to our website.

    Check out my GitHub:
    https://github.com/mitchellsimoens

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •