Results 1 to 5 of 5

Thread: [4.1b2] Inconsistent line endings

    Success! Looks like we've fixed this one. According to our records the fix was applied for EXTJS-5229 in a recent build.
  1. #1
    Sencha User mystix's Avatar
    Join Date
    Mar 2007
    Location
    Singapore
    Posts
    6,236

    Default [4.1b2] Inconsistent line endings

    The following files contain dos-style CRLF line endings
    (all other files contain unix-style line endings):
    Code:
    docs/extjs/examples/draw/Logos.js
    examples/draw/Logos.js
    Suggested fix:
    Run them through dos2unix in a git pre-commit hook.
    Or clobber the dev that committed those files.

  2. #2
    Sencha Premium User mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    40,449

    Default

    This seems really familiar but I can't find any other post. Guess I'm psychic
    Mitchell Simoens @LikelyMitch
    Modus Create, Senior Fullstack Engineer
    ________________
    Modus Create is based on the model of an open source team. We’re a remote, global team of experts in our field. To find out more about the work we do, head over to our website.

    Check out my GitHub:
    https://github.com/mitchellsimoens

  3. #3

  4. #4
    Sencha User mystix's Avatar
    Join Date
    Mar 2007
    Location
    Singapore
    Posts
    6,236

    Default

    This popped up again in 4.1.0-rc2.

    All the files I mentioned previously were fixed, but now there's a new culprit:
    <ext-download>/src/core/test/unit/spec/dom/CompositeElementLite.js

    Please hang the developer responsible for this.
    Or add a git pre-commit hook to take care of this.

  5. #5
    Sencha User mystix's Avatar
    Join Date
    Mar 2007
    Location
    Singapore
    Posts
    6,236

    Default

    Same CRLF problem with

    <ext-download>/src/core/test/unit/spec/dom/CompositeElementLite.js

    in 4.1.0-RC3.

    All other files are fine.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •