Results 1 to 9 of 9

Thread: ActionSheet defines cls instead of baseCls

    Looks like we can't reproduce the issue or there's a problem in the test case provided.
  1. #1
    Ext JS Premium Member
    Join Date
    Apr 2010
    Location
    Omaha, NE
    Posts
    625
    Vote Rating
    39
      0  

    Default ActionSheet defines cls instead of baseCls


  2. #2
    Sencha User Jamie Avins's Avatar
    Join Date
    Mar 2007
    Location
    Redwood City, California
    Posts
    3,661
    Vote Rating
    19
      0  

    Default

    Thank you for the report.

    Sencha Inc

    Jamie Avins

    @jamieavins

  3. #3
    Sencha User Jamie Avins's Avatar
    Join Date
    Mar 2007
    Location
    Redwood City, California
    Posts
    3,661
    Vote Rating
    19
      0  

    Default

    This is intentional. It should get both the baseCls of sheet and action-sheet.

    Sencha Inc

    Jamie Avins

    @jamieavins

  4. #4
    Ext JS Premium Member
    Join Date
    Apr 2010
    Location
    Omaha, NE
    Posts
    625
    Vote Rating
    39
      0  

    Default

    Quote Originally Posted by Jamie Avins View Post
    This is intentional. It should get both the baseCls of sheet and action-sheet.
    I confused on if this was a bug and fixed or intentional? If ActionSheet does use cls then how can we add our own CSS to the ActionSheet?

  5. #5
    Sencha User Jamie Avins's Avatar
    Join Date
    Mar 2007
    Location
    Redwood City, California
    Posts
    3,661
    Vote Rating
    19
      0  

    Default

    cls accepts arrays, you can add as many as you need.

    Sencha Inc

    Jamie Avins

    @jamieavins

  6. #6
    Ext JS Premium Member
    Join Date
    Apr 2010
    Location
    Omaha, NE
    Posts
    625
    Vote Rating
    39
      0  

    Default

    Jamie - I still think ActionClass should use baseCls instead of cls just like all the other Ext components do. Sure, cls takes an array but then I kill the base class for ActionClass which isn't desirable. If ActionSheet needs also needs Sheet's CSS you could do:

    baseCls: Ext.baseCSSPrefix + 'sheet ' + Ext.baseCSSPrefix + 'sheet-action'

    That would allow the users to still add their own CSS to ActionSheet.

    Otherwise we are left with doing this which doesn't seem clean and prone to error if the name changes:

    Code:
    Ext.create('Ext.ActionSheet', {
        cls: [Ext.baseCSSPrefix + 'sheet-action', 'my-custom-cls'],
        ...
    });

  7. #7
    Sencha User Jamie Avins's Avatar
    Join Date
    Mar 2007
    Location
    Redwood City, California
    Posts
    3,661
    Vote Rating
    19
      0  

    Default

    Fair enough. We'll change it over to a baseCls.

    Sencha Inc

    Jamie Avins

    @jamieavins

  8. #8
    Ext JS Premium Member
    Join Date
    Apr 2010
    Location
    Omaha, NE
    Posts
    625
    Vote Rating
    39
      0  

    Default

    Hope I'm not being a pain, but we have two Touch 2.0 development projects going on right now. Hopefully we're doing good testing of the framework and giving you guys useful feedback.

  9. #9
    Sencha User Jamie Avins's Avatar
    Join Date
    Mar 2007
    Location
    Redwood City, California
    Posts
    3,661
    Vote Rating
    19
      0  

    Default

    We appreciate all the feedback we can get. The more our developers can share with us, the better we can make Touch 2.

    Sencha Inc

    Jamie Avins

    @jamieavins

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •