Results 1 to 2 of 2

Thread: Shim for window.attachEvent implemented with Ext Core

  1. #1
    Sencha Premium Member neenhouse's Avatar
    Join Date
    Dec 2007
    Location
    Austin
    Posts
    168
    Vote Rating
    1
      0  

    Question Unanswered: Shim for window.attachEvent implemented with Ext Core

    Hey everybody,

    I have been wrestling a little bit with a relatively simple task. I am updating a legacy system to implement cross-browser API using ext-core and some hand-rolled stuff, but in some cases I need to use a shim. In particular, I need to shim "window.attachEvent" to support compatibility to attach a load and unload event to the window.

    So far this is what I have:

    Code:
    if(!window.attachEvent){
    	window.attachEvent = function(ev,fn){	
    		ev = ev.replace(/^on(.*)/g, "$1"); // slice "on" convention that IE implements, let adapter do the work
    		Ext.fly(window).on(ev, fn);		
    				
    	}
    }
    However, in Firefox, it seems sometimes the shim works and other times it throws a browser error:

    Code:
    // private
    doAdd = function() {
    var ret;
    if (win.addEventListener) {
    ret = function(el, eventName, fn, capture) {
    if (eventName == 'mouseenter') {
    fn = fn.createInterceptor(checkRelatedTarget);
    el.addEventListener(MOUSEOVER, fn, (capture));
    } else if (eventName == 'mouseleave') {
    fn = fn.createInterceptor(checkRelatedTarget);
    el.addEventListener(MOUSEOUT, fn, (capture));
    } else {
    el.addEventListener(eventName, fn, (capture)); // el.addEventListener is not a function
    }
    return fn;
    };
    } else if (win.attachEvent) {
    ret = function(el, eventName, fn, capture) {
    el.attachEvent("on" + eventName, fn);
    return fn;
    };
    } else {
    ret = function(){};
    }
    return ret;
    }(),
    I think the general problem has to do with the different browser nuisances with implement the window object. I just want a simple and elegant way to design my shim that will work. I suppose I could also just do this:

    Code:
    if(!window.attachEvent){
    	window.attachEvent = function(ev,fn){	
    		ev = ev.replace(/^on(.*)/g, "$1"); // slice "on" convention that IE implements, let 
    adapter do the work
                    switch(ev){
                           case "load":
                                 if(window.addEventListener){
                                        window.addEventListener("load",fn,false);
                                 } else {
                                        window.addEventListener("onload",fn);
                                 }
                                 break;
                          case "unload":
                                 if(window.addEventListener){
                                        window.addEventListener("unload",fn,false);
                                 } else {
                                        window.addEventListener("onunload",fn);
                                 }
                                 break;
                          default:
                                 Ext.fly(window).on(ev, fn);	
                                 break;
                    }
    
    				
    	}
    }
    Anyone have a better way?
    I love ext.

  2. #2
    Sencha - Sr Software Engineer mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    39,421
    Answers
    3900
    Vote Rating
    1271
      0  

    Default

    Your third bit of code is a better solution than the first. Sometimes more code is better.
    Mitchell Simoens @LikelyMitch
    Sencha Inc, Senior Software Engineer
    ________________
    Learn BBCode and use it!

    Check out my GitHub, lots of nice things for Ext JS 4 and Sencha Touch 2
    https://github.com/mitchellsimoens

    Think my support is good? Get more personalized support via a support subscription. https://www.sencha.com/store/

    Need more help with your app? Hire Sencha Services services@sencha.com

    Want to learn Sencha Touch 2? Check out Sencha Touch in Action that is in print!

    When posting code, please use BBCode's CODE tags.

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •