Results 1 to 7 of 7

Thread: [4.1.0-rc1] Syntax errors when compiling SASS themes

    Success! Looks like we've fixed this one. According to our records the fix was applied for EXTJS-5661 in a recent build.
  1. #1
    Sencha User mystix's Avatar
    Join Date
    Mar 2007
    Location
    Singapore
    Posts
    6,236

    Default [4.1.0-rc1] Syntax errors when compiling SASS themes

    Same issue all over again:
    http://www.sencha.com/forum/showthre...ng-SASS-themes

    The neptune theme was fixed, but somehow the ext4 theme was either overwritten with an old copy / left out.

    Specifically, the problem is in
    resources/themes/stylesheets/ext4/default/mixins/_frame.scss

    the pad function needs to be moved to the top of the file, just like in the neptune theme.


    [edit]
    Same old problem with the
    resources/themes/stylesheets/ext4/default/widgets/_tabbar.scss
    file as well.

    Mixins cannot be nested. Fixed for neptune theme but not for the ext4 default theme.

  2. #2
    Sencha Premium User mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    40,449

    Default

    The pad function in _frame.scss looks to be resolved.

    In _tabbar.scss you mean the tab-bar-top and tab-bar-bottom mixins not within the extjs-tabbar mixing? Is that what you are referring to?
    Mitchell Simoens @LikelyMitch
    Modus Create, Senior Fullstack Engineer
    ________________
    Modus Create is based on the model of an open source team. We’re a remote, global team of experts in our field. To find out more about the work we do, head over to our website.

    Check out my GitHub:
    https://github.com/mitchellsimoens

  3. #3
    Sencha User mystix's Avatar
    Join Date
    Mar 2007
    Location
    Singapore
    Posts
    6,236

    Default

    In the 4.1.0-rc1 download, the pad function was un-nested by moving it to the top of
    resources/themes/stylesheets/neptune/default/mixins/_frame.scss

    The same pad function remains nested in
    resources/themes/stylesheets/ext4/default/mixins/_frame.scss
    and hence causes the same errors as mentioned in the thread I linked to.


    Likewise, the tab-bar-top and tab-bar-bottom mixins were un-nested by moving them to the bottom of
    resources/themes/stylesheets/neptune/default/widgets/_tabbar.scss

    The same two mixins remain nested in
    resources/themes/stylesheets/ext4/default/widgets/_tabbar.scss
    which likewise causes the same errors as mentioned in the thread I linked to.

  4. #4
    Sencha Premium User mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    40,449

    Default

    Ok. The pad function was moved to the top but the mixins are still nested within another mixin.
    Mitchell Simoens @LikelyMitch
    Modus Create, Senior Fullstack Engineer
    ________________
    Modus Create is based on the model of an open source team. We’re a remote, global team of experts in our field. To find out more about the work we do, head over to our website.

    Check out my GitHub:
    https://github.com/mitchellsimoens

  5. #5
    Sencha User mystix's Avatar
    Join Date
    Mar 2007
    Location
    Singapore
    Posts
    6,236

    Default

    Hi Mitch,

    To be clear -- the pad function was only moved in the neptune theme's _frame.scss file.
    The pad function still causes errors in the ext4 theme's _frame.scss file because it remains nested.
    (unless there's a new 4.1.0-rc1 download which i'm unaware of)

    Sorry for nagging

  6. #6
    Sencha Premium User mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    40,449

    Default

    I'm talking about our latest internal code. In RC1 the pad function was nested but in our latest code for RC2/GA is was moved to the top.
    Mitchell Simoens @LikelyMitch
    Modus Create, Senior Fullstack Engineer
    ________________
    Modus Create is based on the model of an open source team. We’re a remote, global team of experts in our field. To find out more about the work we do, head over to our website.

    Check out my GitHub:
    https://github.com/mitchellsimoens

  7. #7
    Sencha User mystix's Avatar
    Join Date
    Mar 2007
    Location
    Singapore
    Posts
    6,236

    Default

    Thanks for clearing that up

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •