Upgraded to ST2.1 just broke my dataview

[riyaad]

Hi guys,

I've just upgraded from ST2.0.0 to ST2.1. I'm getting the following error (attached image)...

Screen Shot 2012-11-07 at 11.21.45 AM.jpg

Note that "app.js.716" points to my dataview (below the error)

        var schedule = Ext.create('Ext.DataView', {
            itemTpl: tpl,
            store: offlineStore,
            scrollable: true,
            emptyText: '<div style="margin-top: 20px; text-align: center">empty …nothing</div>',
....

Can anyone advise please?

Thank you,
Riyaad

[mitchellsimoens]

Looks like you are trying to use the PullRefresh plugin. This was only ever meant to work with Ext.dataview.List so it may have worked before but was not meant to work in Ext.dataview.DataView

[riyaad]

Hi Mitchell,

That would be correct, I'm using the PullRefresh plugin to allow the user to update his/her details in the dataview (info being pulled from offline store etc). So are you saying that as of v2.1 that this is no longer allowed in the dataview and that I may need to use the list instead (unless I decide to remove the PullRefresh plugin)?

Regards
R

[mitchellsimoens]

Correct. That plugin is designed to only work with List and the List in 2.1 has changed to support infinite scrolling.

[matfin]

Hi,

Thanks for that info. I think the documentation should be updated to reflect this. Will add a comment now.

Thanks,

Matt

[Gaspard22]

i want the pullrefresh plugin (on my Ext.List) but where do i find the plugin ?

thanks

[jweber]

I had a similar problem, and ended up making a copy of the PullRefresh plugin, but without the List-specific code.

I think this plugin would be a good candidate for refactoring. There's the user-interface portion, which people might want to use on any component. And then there's the store-related code, which is only useful for DataViews. Maybe the latter could be moved into an adapter class, so the UI code is more reusable.

[zlesko]

Would you mind posting that code? I am using both PullRefresh and ListPaging plugins with my DataViews.

[jweber]

To make it work with DataView, I think you only need to change line 147:

        list.container.insert(0, me);

to something like:

        list.container ? list.container.insert(0, me) : list.insert(0, me);

My code has gone in a different direction since I did this, so there might be other changes that I forgot about.