Results 1 to 2 of 2

Thread: Ext.Array.forEach - redundant return statement

Hybrid View

Previous Post Previous Post   Next Post Next Post
    Success! Looks like we've fixed this one. According to our records the fix was applied for EXTJS-7777 in a recent build.
  1. #1
    Sencha Premium User
    Join Date
    Nov 2010
    Vote Rating

    Default Ext.Array.forEach - redundant return statement

    This is a minor point, but the return statement below is redundant because the native Array.forEach implementation has no return value, and if it did have a return value, then it would not be consistent with the non-native implementation which doesn't have the return statement.

    As a side note, I'm not sure why the native implementation doesn't return the array. It would be nice if it did, then we would be able to chain forEach.

    Ext.Array.forEach could also return the array, but then the api would not be conformant with the native api.

    ExtArray = Ext.Array = {
        forEach: supportsForEach ? function(array, fn, scope) {
            return array.forEach(fn, scope); // <==== return not needed
        } : function(array, fn, scope) {
            var i = 0,
                ln = array.length;
            for (; i < ln; i++) {
      , array[i], i, array);

  2. #2
    Sencha User mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Gainesville, FL
    Vote Rating


    thanks for the report
    Mitchell Simoens @LikelyMitch
    Modus Create, Senior Frontend Engineer
    Need any sort of Ext JS help? Modus Create is here to help!

    Check out my GitHub:

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts