Results 1 to 2 of 2

Thread: An Override to disable/enable the PullRefresh plugin

Hybrid View

Previous Post Previous Post   Next Post Next Post
  1. #1
    Sencha User
    Join Date
    Nov 2010
    Posts
    118
    Vote Rating
    9
      0  

    Default An Override to disable/enable the PullRefresh plugin

    My only gripe with this otherwise sweet plugin is that disabling it has no effect. This is common with plugins (including some that I've written), but I thought it might be good if it could be toggled on and off. In my latest project, I accomplish this with the following override:
    Code:
    Ext.define('Ext.plugin.PullRefreshToggleable',{
        override:'Ext.plugin.PullRefresh',
        
        //Hide/show the visual component based on if the plugin is disabled/enabled
        setDisabled:function(isHidden){
            this.setHidden(isHidden);
            this.callParent(arguments);
        },
        
        //Only let handlers do their thing if the plugin is enabled
        onScrollChange:function(){
            if(!this.isDisabled()){
                this.callParent(arguments);
            }
        },
        onBounceTop:function(){
            if(!this.isDisabled()){
                this.callParent(arguments);
            }
        },
        onScrollerDragEnd:function(){
            if(!this.isDisabled()){
                this.callParent(arguments);
            }
        }
    });
    This way, a developer can use plugin.setDisabled() as you might expect. plugin.disable() and plugin.enable() should work too, but I haven't tested that. If people like it, maybe someone could add it to the *official* code?

  2. #2
    Sencha - Sr Software Engineer mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    39,326
    Vote Rating
    1297
      0  

    Default

    Thanks for the contribution.
    Mitchell Simoens @LikelyMitch
    Sencha Inc, Senior Software Engineer
    ________________
    Learn BBCode and use it!

    Check out my GitHub, lots of nice things for Ext JS 4 and Sencha Touch 2
    https://github.com/mitchellsimoens

    Think my support is good? Get more personalized support via a support subscription. https://www.sencha.com/store/

    Need more help with your app? Hire Sencha Services services@sencha.com

    Want to learn Sencha Touch 2? Check out Sencha Touch in Action that is in print!

    When posting code, please use BBCode's CODE tags.

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •