Results 1 to 4 of 4

Thread: [4.2.0.265] Store "add" event firing contract changed

  1. #1
    Sencha Premium User mankz's Avatar
    Join Date
    Nov 2007
    Location
    Stockholm, Sweden
    Posts
    3,138
    Vote Rating
    189
      0  

    Default [4.2.0.265] Store "add" event firing contract changed

    Ext.data.Store does:

    Code:
     add: function(arg) {
    
            
            if (Ext.isArray(arg)) {
                records = arg;
            } else {
                records = arguments;  // BOOOOOOOOH
            }

    Should normalize it to real array. Any 'instanceof Array' or Ext.isArray checks on the Records param fails now... Docs would also be lying right now since they state it should be an Array of records.

  2. #2
    Sencha User evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    19,010
    Vote Rating
    940
      0  

    Default

    Care to elaborate? At what point are you overriding it?
    Twitter - @evantrimboli
    Former Sencha framework engineer, available for consulting.
    As of 2017-09-22 I am not employed by Sencha, all subsequent posts are my own and do not represent Sencha in any way.

  3. #3
    Sencha Premium User mankz's Avatar
    Join Date
    Nov 2007
    Location
    Stockholm, Sweden
    Posts
    3,138
    Vote Rating
    189
      0  

    Default

    Well, we have code similar to:

    Code:
    store.on({
        add : refresh,
        update : refresh,
        remove : refresh
    })
    In the refresh method, we normalize to Array based on

    Code:
     refresh: function (store, records) {
            var toDraw  = [];
    
            if (!Ext.isArray(records)) {
                records = [records];
            }
    4.2.0.265 breaks this, don't think we're the only ones.

  4. #4
    Sencha User evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    19,010
    Vote Rating
    940
      0  

    Default

    Ah, so you're saying the problem is with what's fired by the event/return value? If so, that's already taken care of: EXTJSIV-8201 for your reference.
    Twitter - @evantrimboli
    Former Sencha framework engineer, available for consulting.
    As of 2017-09-22 I am not employed by Sencha, all subsequent posts are my own and do not represent Sencha in any way.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •