Results 1 to 4 of 4

Thread: Would be nice to use theme inheritance also for images

    Looks like we can't reproduce the issue or there's a problem in the test case provided.
  1. #1
    Sencha Premium User SebTardif's Avatar
    Join Date
    Feb 2011
    Location
    Cambridge, MA
    Posts
    1,036
    Vote Rating
    94
      1  

    Default Would be nice to use theme inheritance also for images

    At http://cdn.sencha.com/ext/beta/4.2.0...ase-notes.html we can read:
    Themes use theme inheritance to share code and resources between each other.
    ...
    The Gray ("ext-theme-gray"), Accessibility ("ext-theme-access") and Classic Sandbox ("ext-theme-classic-sandbox") themes all extend Classic.
    However, when comparing ext-theme-classic and ext-theme-access half are copy/paste.

    Folder Compare
    Produced: 3/19/2013 11:44:25 AM

    Mode: All
    Left base folder: ext-theme-classic\resources\images
    Right base folder: ext-theme-access\resources\images
    FileStats.PNG

  2. #2
    Sencha - Sr Software Engineer mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    39,335
    Vote Rating
    1297
      0  

    Default

    Thanks for the report! I have opened a bug in our bug tracker.

  3. #3
    Sencha - Ext JS Dev Team dongryphon's Avatar
    Join Date
    Jul 2009
    Location
    Kansas
    Posts
    1,694
    Vote Rating
    232
      0  

    Default

    Are you saying that the mechanism does not copy base theme images for you? Or that we have some baggage in our themes that needs cleanup?

    If the former then that would be a serious bug. Resources from base themes are copied to derived themes in the build process if the derived theme does not have a replacement.

    I suspect the later because the leaf-most themes (gray and access) have not been combed over to eliminate duplicates. In the end they are just a minor issue because the build would produce the duplication anyway. Still something we will want to cleanup of course.

    Just want to be sure I understand the OP here.
    Don Griffin
    Director of Engineering - Frameworks (Ext JS / Sencha Touch)

    Check the docs. Learn how to (properly) report a framework issue and a Sencha Cmd issue

    "Use the source, Luke!"

  4. #4
    Sencha Premium User SebTardif's Avatar
    Join Date
    Feb 2011
    Location
    Cambridge, MA
    Posts
    1,036
    Vote Rating
    94
      0  

    Default

    This was about that we have some baggage in our themes that needs cleanup.

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •