Threaded View

    Success! Looks like we've fixed this one. According to our records the fix was applied for EXTJS-9389 in a recent build.
  1. #1
    Sencha User Wedgybo's Avatar
    Join Date
    Jul 2011
    Edinburgh, Scotland
    Vote Rating
    Wedgybo will become famous soon enough


    Default Best practice for overriding SASS mixins with new package structure.

    Hi guys,

    I'm just wondering what everyones thoughts are on overriding mixins on the new theme structure?

    Previously we would create a whole new theme and edit the mixin directly and then workout the differences between new ExtJS versions using a diff and apply any changes that were relevant to our mixin. Super messy!

    Now that we are extending an official themes, we still want to editing the original mixins. Currently we are just creating a file, in src/window/Window.scss for example, that copies the whole mixin from the natural theme. Then editing what we want to change.

    Now this appears to work OK because our one is loaded last, but still feels messy, especially after all this work has been done by Sencha to make theme editing a lot more managed!

    If anyone has any insight it would be great to hear it!

    UPDATE: Just noticed that this practice causes an error in the slicer when packaging the theme.

    The widget undefined declares two corners with two different urls
    == Unhandled Error ==
    The widget undefined declares two corners with two different urls

    phantomjs://webpage.evaluate():63 in err
    phantomjs://webpage.evaluate():68 in forEach
    phantomjs://webpage.evaluate():32 in getSlices
    phantomjs://webpage.evaluate():68 in forEach
    Last edited by Wedgybo; 29 Mar 2013 at 4:42 AM. Reason: Adding error