Results 1 to 3 of 3

Thread: [4.2] Chart - refreshBuffer used but not documented

    Success! Looks like we've fixed this one. According to our records the fix was applied for EXTJS-9958 in 4.2.2.1144.
  1. #1
    Sencha Premium User
    Join Date
    Nov 2010
    Location
    Chicago
    Posts
    1,932
    Vote Rating
    548
      0  

    Default [4.2] Chart - refreshBuffer used but not documented

    I'd like to point out what I believe is a code or documentation issue in the Chart class.

    me.refreshBuffer is not documented or referenced anywhere in the chart package.

    When I search the entire Ext JS code base I get '1 match in 1 file'.

    Code:
    Ext.define('Ext.chart.Chart', {
        ...
        // @private buffered refresh for when we update the store
        delayRefresh: function() {
            var me = this;
            if (!me.refreshTask) {
                me.refreshTask = new Ext.util.DelayedTask(me.refresh, me);
            }
            me.refreshTask.delay(me.refreshBuffer); // <-- refreshBuffer is not documented or referenced
        },
        ....

  2. #2
    Sencha - Sr Software Engineer mitchellsimoens's Avatar
    Join Date
    Mar 2007
    Location
    Gainesville, FL
    Posts
    39,551
    Vote Rating
    1271
      0  

    Default

    Thanks for the report
    Mitchell Simoens @LikelyMitch
    Sencha Inc, Senior Software Engineer
    ________________
    Learn BBCode and use it! Checkout the CODE tag!

    Check out my GitHub, lots of nice things for Ext JS and Sencha Touch
    https://github.com/mitchellsimoens

  3. #3
    Sencha Premium User
    Join Date
    Nov 2010
    Location
    Chicago
    Posts
    1,932
    Vote Rating
    548
      0  

    Default

    Please check the DelayedTask dependency in the Chart class. Component already uses DelayedTask.

    Code:
    Ext.define('Ext.Component', {
        ...
        uses: [
            'Ext.util.DelayedTask',
            'Ext.Layer',
            'Ext.resizer.Resizer',
            'Ext.util.ComponentDragger'
        ],
        ...
    
    
    
    
    Ext.define('Ext.chart.Chart', {
        ...
        requires: [
            'Ext.util.MixedCollection',
            'Ext.data.StoreManager',
            'Ext.chart.Legend',
            'Ext.chart.theme.Base',
            'Ext.chart.theme.Theme',
            'Ext.util.DelayedTask' // <--- Is this needed?
        ],    
        ...

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •