Results 1 to 2 of 2

Thread: tagfield config filterPickList implementation partly broken

    Success! Looks like we've fixed this one. According to our records the fix was applied for EXTJS-14110 in 5.0.1.
  1. #1
    Sencha Premium Member
    Join Date
    Apr 2008
    Posts
    369

    Default tagfield config filterPickList implementation partly broken

    Code:
        onValueStoreRemove: function() {
            
            
            
            if (this.filterPickList) {
                this.store.filter();
            }
        },
    
        onValueStoreChange: function() {
            
            
            
            if (this.filterPickList) {
                this.store.filter();
            }
            this.applyMultiselectItemMarkup();
        },
    #1 the component doesn't need both of these event handlers, the change one I believe will always run after the remove one
    #2 calling store.filter() doesn't cause the store to be refiltered. The existing filters need to be forced to be re-applied even though neither the target store or its filters list changes. The filter used here is supposed to hide values from the menu that are already added to the valueStore. This works with initial values right now but currently when the valueStore is changed the main store's filters aren't reapplied to hide newly selected values.

    Update #1: here's a fiddle, when you select items from the popup they're supposed to be removed from the popup list: https://fiddle.sencha.com/#fiddle/7ga

    Update #2: here's a hotfix override: https://github.com/JarvusInnovations...terPickList.js

    Update #3: I've included this hotfix in our hotfix packages for 5.0.0.736 and 5.0.0.970: https://github.com/JarvusInnovations/sencha-hotfixes
    Chief Architect @ Jarv.us Innovations
    Co-captain @ Code for Philly

    Jarvus builds and optimizes top-quality Sencha Touch and ExtJS apps for open-source projects and clients of all sizes.

    Don't waste time with bugs that have already been found and fixed by the community, compile our tried and tested hotfixes packages into all your projects: https://github.com/JarvusInnovations/sencha-hotfixes

  2. #2
    Sencha Premium User evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    19,253

    Default

    Thanks for the report! I have opened a bug in our bug tracker.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •