Page 2 of 2 FirstFirst 12
Results 11 to 16 of 16

Thread: RowEditing Buttons not visible

    You found a bug! We've classified it as EXTJS-19471 . We encourage you to continue the discussion and to find an acceptable workaround while we work on a permanent fix.
  1. #11
    Sencha Premium User
    Join Date
    Jun 2011
    Location
    Perth, Western Australia
    Posts
    182

    Default

    I had the same in 6.2.2.90

    I set
    minHeight: 140 // fixed

    ... you probably already knew that

  2. #12
    Sencha User
    Join Date
    Apr 2013
    Posts
    914

    Default

    Quote Originally Posted by wemerson.januario View Post
    I have the same problem. Override please
    How hard is it to scroll slightly up and see that mmayer has posted an override long time ago?

  3. #13
    Sencha Premium User
    Join Date
    Mar 2013
    Posts
    4

    Default

    Quote Originally Posted by fairport View Post
    I had the same in 6.2.2.90

    I set
    minHeight: 140 // fixed

    ... you probably already knew that
    @fairport, where did you set it?

    I am using 6.5.2 and non of the proposed solutions seem to work.

  4. #14
    Sencha Premium User
    Join Date
    Mar 2013
    Posts
    4

    Default

    Seems to be fixed in 6.5.3

  5. #15
    Sencha Premium User
    Join Date
    Mar 2013
    Posts
    4

    Default

    Quote Originally Posted by dominikpfaffenbauer View Post
    Seems to be fixed in 6.5.3
    doesn't seem to be fixed at all, here is my quick fix solution:

    Code:
    Ext.define('RCTec.overrides.grid.RowEditor', {
        override: 'Ext.grid.RowEditor',
    
    
        // determines the amount by which the row editor will overflow, and flips the buttons
        // to the top of the editor if the required scroll amount is greater than the available
        // scroll space. Returns the scrollDelta required to scroll the editor into view after
        // adjusting the button position.
        syncButtonPosition: function (context) {
            var me = this,
                scrollDelta = me.getScrollDelta(),
                floatingButtons = me.getFloatingButtons(),
                scrollingView = me.scrollingView,
                // If this is negative, it means we're not scrolling so lets just ignore it
                scrollHeight = Math.max(0, me.scroller.getSize().y - me.scroller.getClientSize().y),
                overflow = scrollDelta - (scrollHeight - me.scroller.getPosition().y);
    
    
            floatingButtons.show();
    
    
            // If that's the last visible row, buttons should be at the top regardless of scrolling,
            // but not if there is just one row which is both first and last.
            if (overflow > 0 || (context.rowIdx > 2 && context.isLastRenderedRow())) {
                if (!me._buttonsOnTop) {
                    floatingButtons.setButtonPosition('top');
                    me._buttonsOnTop = true;
                    me.layout.setAlign('bottom');
                    me.updateLayout();
                }
                scrollDelta = 0;
            } else if (me._buttonsOnTop !== false) {
                floatingButtons.setButtonPosition('bottom');
                me._buttonsOnTop = false;
                me.layout.setAlign('top');
                me.updateLayout();
            }
            // Ensure button Y position is synced with Editor height even if button
            // orientation doesn't change
            else {
                floatingButtons.setButtonPosition(floatingButtons.position);
            }
    
    
            return scrollDelta;
        },
    });
    It is this line which fixes is for me

    Code:
    if (overflow > 0 || (context.rowIdx > 2 && context.isLastRenderedRow())) {
    NOTE: This is not a generic fix, I just wanted to share my quick fix solution.

  6. #16
    Sencha Premium Member
    Join Date
    Mar 2009
    Posts
    1

    Default

    I had this issue in Ext 6.6, still an issue, here is the override I used;

    Code:
    Ext.define('Ext.overrides.grid.RowEditor', {
        override : 'Ext.grid.RowEditor',
    
    showTipBelowRow : true,
    
    syncButtonPosition: function(context) {
            var me = this,
    scrollDelta = me.getScrollDelta(),
    floatingButtons = me.getFloatingButtons(),
    scrollingView = me.scrollingView,
    // If this is negative, it means we're not scrolling so lets just ignore it
    scrollHeight = Math.max(0, me.scroller.getSize().y - me.scroller.getClientSize().y),
    overflow = scrollDelta - (scrollHeight - me.scroller.getPosition().y);
    floatingButtons.show();
    // If that's the last visible row, buttons should be at the top regardless of scrolling,
            // but not if there is just one row which is both first and last.
            //  SONY OVERRIDE:
            //                  Do not put on TOP if selected row is 0 or 1, , so need idx > 1 or buttons will be hidden ( orig code had idx > 0)
            // if (overflow > 0 || (context.rowIdx > 0  && context.isLastRenderedRow())) {
    if (overflow > 0 || (context.rowIdx > 1 && context.isLastRenderedRow())) {
                if (!me._buttonsOnTop) {
                    floatingButtons.setButtonPosition('top');
    me._buttonsOnTop = true;
    me.layout.setAlign('bottom');
    me.updateLayout();
    }
                scrollDelta = 0;
    } else if (me._buttonsOnTop !== false) {
                floatingButtons.setButtonPosition('bottom');
    me._buttonsOnTop = false;
    me.layout.setAlign('top');
    me.updateLayout();
    } else // Ensure button Y position is synced with Editor height even if button
            // orientation doesn't change
    {
                floatingButtons.setButtonPosition(floatingButtons.position);
    }
            return scrollDelta;
    },
    

Page 2 of 2 FirstFirst 12

Similar Threads

  1. Custom RowEditing buttons in Ext 5
    By srikanthradix in forum Ext 5: Q&A
    Replies: 3
    Last Post: 22 Jan 2016, 6:49 AM
  2. Replies: 3
    Last Post: 15 Dec 2014, 8:01 AM
  3. Replies: 5
    Last Post: 15 Oct 2013, 8:06 AM
  4. Grid Rowediting - Icon on Buttons
    By siggi in forum Ext: Q&A
    Replies: 1
    Last Post: 7 Aug 2013, 10:32 AM
  5. Buttons update cancel rowediting
    By Fanny144 in forum Ext:User Extensions and Plugins
    Replies: 3
    Last Post: 8 Jul 2011, 1:19 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •