Results 1 to 7 of 7

Thread: [FIXED][3.0] Grid ColumnModel text items missing from locale files

    You found a bug! We've classified it as a bug in our system. We encourage you to continue the discussion and to find an acceptable workaround while we work on a permanent fix.
  1. #1
    Sencha User Animal's Avatar
    Join Date
    Mar 2007
    Location
    Bédoin/Nottingham
    Posts
    30,891
    Vote Rating
    89
      0  

    Default [FIXED] [3.0] Grid ColumnModel text items missing from locale files

    In src/widgets/grid/Column.js:

    Code:
    Ext.grid.BooleanColumn = Ext.extend(Ext.grid.Column, {
        /**
         * @cfg {String} trueText
         * The text used
         */
        trueText: 'true',
        falseText: 'false',
        undefinedText: '?',
    
        constructor: function(cfg){
            this.supr().constructor.apply(this, arguments);
            var t = this.trueText, f = this.falseText, u = this.undefinedText;
            this.renderer = function(v){
                if(v === undefined){
                    return u;
                }
                if(!v || v === 'false'){
                    return f;
                }
                return t;
            };
        }
    });
    Needs an extra section in the locale files:

    Code:
    if(Ext.grid.BooleanColumn){
       Ext.apply(Ext.grid.BooleanColumn.prototype, {
          trueText  : "true",
          falseText : "false"
       });
    }
    And DateColumn should used the localized renderer which is configured into Ext.util.Format by the locale file rather than generating another renderer using 'm/d/Y'. Code should be:

    Code:
    Ext.grid.DateColumn = Ext.extend(Ext.grid.Column, {
        constructor: function(cfg){
            this.supr().constructor.apply(this, arguments);
            this.renderer = Ext.util.Format.date;
        }
    });
    Last edited by mystix; 15 Jun 2009 at 6:21 PM. Reason: moved to 3.x Bugs from 2.x Bugs

  2. #2
    Sencha User Animal's Avatar
    Join Date
    Mar 2007
    Location
    Bédoin/Nottingham
    Posts
    30,891
    Vote Rating
    89
      0  

    Default

    Column class still contains these problems.

  3. #3
    Sencha User Animal's Avatar
    Join Date
    Mar 2007
    Location
    Bédoin/Nottingham
    Posts
    30,891
    Vote Rating
    89
      0  

    Default

    Last bump before 3.0 release!

  4. #4
    Sencha Premium User evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    19,196
    Vote Rating
    1002
      0  

    Default

    They've been added to the default locale file. Obviously the rest of them need to be filled with the appropriate content.
    Twitter - @evantrimboli
    Former Sencha framework engineer, available for consulting.
    As of 2017-09-22 I am not employed by Sencha, all subsequent posts are my own and do not represent Sencha in any way.

  5. #5
    Ext User
    Join Date
    Jul 2007
    Location
    Florida
    Posts
    9,996
    Vote Rating
    8
      0  

    Default

    Should we add some kind of locale thread that we can bump when something in the locale directory changes? That way people can subscribe to it and then contribute their updates? I'm not sure how that has worked in the past.

  6. #6
    Sencha User mystix's Avatar
    Join Date
    Mar 2007
    Location
    Singapore
    Posts
    6,236
    Vote Rating
    5
      0  

    Default

    Quote Originally Posted by mjlecomte View Post
    Should we add some kind of locale thread that we can bump when something in the locale directory changes? That way people can subscribe to it and then contribute their updates? I'm not sure how that has worked in the past.
    there used to be a stickied Translations thread in the Open Discussion Forum for that purpose.

  7. #7
    Sencha User mystix's Avatar
    Join Date
    Mar 2007
    Location
    Singapore
    Posts
    6,236
    Vote Rating
    5
      0  

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •