Results 1 to 5 of 5

Thread: [FIXED][3.0] Tooltip.js anchorEl is taking up space

    Thank you for reporting this bug. We will make it our priority to review this report.
  1. #1
    Ext JS Premium Member stever's Avatar
    Join Date
    Mar 2007
    Posts
    1,408
    Vote Rating
    9
      0  

    Default [FIXED][3.0] Tooltip.js anchorEl is taking up space

    The tooltip div now has a anchorEl div that is added to the body, and takes up space even when hidden since visibility:hidden divs still take space (as opposed to display:none divs). It could use display:none, or it could use offsets and be positioned absolutely. I propose display:none simply because it is an easy fix.

    Original:
    PHP Code:
        onRender : function(ctposition){
            
    Ext.ToolTip.superclass.onRender.call(thisctposition);
            
    this.anchorCls 'x-tip-anchor-' this.getAnchorPosition();
            
    this.anchorEl ct.createChild({
                
    cls'x-tip-anchor ' this.anchorCls
            
    });
        } 
    Proposed:
    PHP Code:
        onRender : function(ctposition){
            
    Ext.ToolTip.superclass.onRender.call(thisctposition);
            
    this.anchorCls 'x-tip-anchor-' this.getAnchorPosition();
            
    this.anchorEl ct.createChild({
                
    cls'x-tip-anchor ' this.anchorCls
            
    });
            
    this.anchorEl.setVisibilityMode(Ext.Element.DISPLAY);
        } 

  2. #2
    Sencha Premium User evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    19,211
    Vote Rating
    1005
      0  

    Default

    Fixed in SVN.
    Twitter - @evantrimboli
    Former Sencha framework engineer, available for consulting.
    As of 2017-09-22 I am not employed by Sencha, all subsequent posts are my own and do not represent Sencha in any way.

  3. #3
    Ext JS Premium Member stever's Avatar
    Join Date
    Mar 2007
    Posts
    1,408
    Vote Rating
    9
      0  

    Default

    I guess the fix had a side effect of some sort? r3648 says "the anchor floats anyway" -- floating still takes space. Now if you were to absolutely position it, then that would be another story.

    The screenshot shows how now our page has a scrollbar and extra space at the bottom, both are fixed when that extra line is there. It could be hidden some other way too, just that way was easy.
    Attached Images Attached Images
    Last edited by stever; 9 Apr 2009 at 3:10 PM. Reason: Added screenshot

  4. #4
    Ext JS Premium Member stever's Avatar
    Join Date
    Mar 2007
    Posts
    1,408
    Vote Rating
    9
      0  

    Default

    Oh, I see what you mean by floating:

    Code:
    floating:{shadow:true,shim:true,useDisplay:true,constrain:false},
    Note the useDisplay is true. The thing is, the anchor is not in the DOM as a child of the component's element -- it is a sibling (use firebug and look at the DOM). So it does not get any of those settings.

  5. #5
    Sencha Premium User evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    19,211
    Vote Rating
    1005
      0  

    Default

    Modified it so the anchor is now a child element of the tooltip, seems to work fine.
    Twitter - @evantrimboli
    Former Sencha framework engineer, available for consulting.
    As of 2017-09-22 I am not employed by Sencha, all subsequent posts are my own and do not represent Sencha in any way.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •