Results 1 to 10 of 19

Thread: [FIXED][3.0RC1]bodyStyle not applied padding

Hybrid View

Previous Post Previous Post   Next Post Next Post
    Thank you for reporting this bug. We will make it our priority to review this report.
  1. #1
    Sencha User
    Join Date
    Jul 2007
    Location
    Moscow, Russia
    Posts
    295
    Vote Rating
    0
      0  

    Default [FIXED][3.0RC1]bodyStyle not applied padding

    Hi, with ext 2.2.1 working great, but now padding not applied for any cmp.
    For example:
    Code:
    Ext.Window({
        bodyStyle: 'background: #cad9ec; padding: 7px 7px 0 7px',
    });
    New config attributes or anything else?

  2. #2
    Sencha User Condor's Avatar
    Join Date
    Mar 2007
    Location
    The Netherlands
    Posts
    24,246
    Vote Rating
    132
      0  

    Default

    No, applyStyles no longer trims whitespace (should this be classified as a bug?).

    This should work:
    Code:
    bodyStyle: 'background:#cad9ec;padding:7px 7px 0 7px',

  3. #3
    Sencha User
    Join Date
    Jul 2007
    Location
    Moscow, Russia
    Posts
    295
    Vote Rating
    0
      0  

    Default

    Ohh, thank you!
    IMO, this is bug, because clean code markup with whitespaces is good practice.

  4. #4
    Sencha User Condor's Avatar
    Join Date
    Mar 2007
    Location
    The Netherlands
    Posts
    24,246
    Vote Rating
    132
      0  

    Default

    I'll move this thread to the bugs section...

  5. #5
    Sencha Premium User evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    19,234
    Vote Rating
    1015
      0  

    Default

    Fixed in SVN, strings will now be trimmed appropriately.
    Twitter - @evantrimboli
    Former Sencha framework engineer, available for consulting.
    As of 2017-09-22 I am not employed by Sencha, all subsequent posts are my own and do not represent Sencha in any way.

  6. #6
    Sencha User Animal's Avatar
    Join Date
    Mar 2007
    Location
    Bédoin/Nottingham
    Posts
    30,890
    Vote Rating
    89
      0  

    Default

    I'm not sure that the solution is the best. Perhaps some benchmarking could be done?

    Generating a trim function on every trip through applyStyles must be a bit inefficient. Wouldn't using String's Ext-supplied trim call on each element be better?

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •