Results 1 to 2 of 2

Thread: [CLOSED][3.??] DatePicker memory leak sIEve

    Thank you for reporting this bug. We will make it our priority to review this report.
  1. #1
    Sencha User
    Join Date
    Nov 2009
    Location
    France
    Posts
    23
    Vote Rating
    0
      0  

    Exclamation [CLOSED][3.??] DatePicker memory leak sIEve

    Hi,

    found a memory leak using DatePicker (seen with IE6 & IE8).
    After some code checking, i saw that 2 attributes were used :

    - this.prevRepeater,
    - this.nextRepeater

    but in the beforeDestroy, we destroy inexisting attributes :

    this.leftClickRpt,
    this.rightClickRpt

    I think these ones are older and had been renamed with prevRepeater & nextRepeater.

    So, bugfixed in beforeDestroy by replacing with good names.


    I think that at the end of the beforeDestroy, we must call the super.beforeDestroy, otherwise we don't respect hierarchy call and all super will be ignored







    Code:
     
    beforeDestroy : function() {
    if(this.rendered){
    if (this.keyNav){
    this.keyNav.disable();
    }
    this.keyNav = null;
    Ext.destroy( this.prevRepeater, this.nextRepeater, this.monthPicker, this.eventEl, this.mbtn, this.todayBtn ); } Ext.DatePicker.superclass.beforeDestroy.call(this);
    }

  2. #2
    Sencha User evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    18,984
    Vote Rating
    933
      0  

    Default

    Thanks for the report, however this is already fixed in SVN.
    Twitter - @evantrimboli
    Former Sencha framework engineer, available for consulting.
    As of 2017-09-22 I am not employed by Sencha, all subsequent posts are my own and do not represent Sencha in any way.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •