Results 1 to 4 of 4

Thread: [FIXED-515][3.1.1 rc] Ext.Toolbar#enableOverflow (patch)

    Thank you for reporting this bug. We will make it our priority to review this report.
  1. #1
    Sencha User
    Join Date
    Jun 2008
    Posts
    70
    Vote Rating
    0
      0  

    Default [FIXED-515][3.1.1 rc] Ext.Toolbar#enableOverflow (patch)

    The documentation tells that Ext.Toolbar#enableOverflow is false by default. This is not true; it's not initialized at all. This has the result that the check "this.container.enableOverflow === false" returns false and performance expensive dom operations are executed (Firebug profiler tells about 10% in my case).

    The following override fixes this issue:

    Code:
    Ext.override(Ext.Toolbar, {
        enableOverflow: false
    });
    Tocco AG - technology meets spirit
    http://www.tocco.ch

  2. #2
    Sencha User
    Join Date
    Jun 2008
    Posts
    70
    Vote Rating
    0
      0  

    Default

    It looks like you have changed something in this area for 3.1.1 RC. Though it does not fix the issue in a global way. Why don't you use my override, which would fix it?
    Tocco AG - technology meets spirit
    http://www.tocco.ch

  3. #3
    Sencha - Ext JS Dev Team evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    18,379
    Vote Rating
    858
      0  

    Default

    Jamie did exactly that, in rev 5978.
    Evan Trimboli
    Sencha Developer
    Twitter - @evantrimboli
    Don't be afraid of the source code!

  4. #4
    Sencha User Jamie Avins's Avatar
    Join Date
    Mar 2007
    Location
    Redwood City, California
    Posts
    3,661
    Vote Rating
    19
      0  

    Default

    Thanks Evan, I forgot to post it is now in SVN 5978.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •